How to not sound passive aggressive in code reviews?
up vote
0
down vote
favorite
As a young guy in my first programming job, I can't figure out how to avoid sounding passive aggressive when providing code review comments or when responding to such comments in my own code. It invariably ends up sounding like "X does Y, not Z. It's not needed here." in response to something like "don't we need to call function X here?".
So how do you properly respond to general review comments like "I think this is missing here" or "I think this is not needed here"? And how do you correct a coworker's misunderstanding without sounding snappy?
I'm asking because a coworker said "I think this comment doesn't accurately describe the code because X actually does Y". I was going to respond with "X actually doesn't do Y. Z is the one that actually does Y". However, it just sounds slightly snarky. I for sure would be a little annoyed if someone responded to me like that.
colleagues code
asked 1 hour ago
Jonathan Park
104
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
up vote
0
down vote
favorite
As a young guy in my first programming job, I can't figure out how to avoid sounding passive aggressive when providing code review comments or when responding to such comments in my own code. It invariably ends up sounding like "X does Y, not Z. It's not needed here." in response to something like "don't we need to call function X here?".
So how do you properly respond to general review comments like "I think this is missing here" or "I think this is not needed here"? And how do you correct a coworker's misunderstanding without sounding snappy?
I'm asking because a coworker said "I think this comment doesn't accurately describe the code because X actually does Y". I was going to respond with "X actually doesn't do Y. Z is the one that actually does Y". However, it just sounds slightly snarky. I for sure would be a little annoyed if someone responded to me like that.
colleagues code
asked 1 hour ago
Jonathan Park
104
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
1
Have you noticed the way others respond in code reviews? Have you seen cases where their responses didn't come across as passive-aggressive? Do that. Just stick with the facts and avoid passive-aggressive amplifiers like "actually" as much as you can.
– Joe Strazzere
1 hour ago
This seems highly dependent on culture and the personalities of those involved, and the specifics of the comment. Some don't really pick up on or mind snark and might dislike unnecessary sugarcoating, while others find snark in many things and appreciate some kinder ways of putting things. And someone might consider something snarky when it's said by one person, but not when it's said by another. Although you should always, within reason, try to avoid explaining or stating things others find obvious and always give the benefit of the doubt when interpreting what others say.
– Dukeling
34 mins ago
add a comment |
up vote
0
down vote
favorite
up vote
0
down vote
favorite
As a young guy in my first programming job, I can't figure out how to avoid sounding passive aggressive when providing code review comments or when responding to such comments in my own code. It invariably ends up sounding like "X does Y, not Z. It's not needed here." in response to something like "don't we need to call function X here?".
So how do you properly respond to general review comments like "I think this is missing here" or "I think this is not needed here"? And how do you correct a coworker's misunderstanding without sounding snappy?
I'm asking because a coworker said "I think this comment doesn't accurately describe the code because X actually does Y". I was going to respond with "X actually doesn't do Y. Z is the one that actually does Y". However, it just sounds slightly snarky. I for sure would be a little annoyed if someone responded to me like that.
colleagues code
asked 1 hour ago
Jonathan Park
104
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
As a young guy in my first programming job, I can't figure out how to avoid sounding passive aggressive when providing code review comments or when responding to such comments in my own code. It invariably ends up sounding like "X does Y, not Z. It's not needed here." in response to something like "don't we need to call function X here?".
So how do you properly respond to general review comments like "I think this is missing here" or "I think this is not needed here"? And how do you correct a coworker's misunderstanding without sounding snappy?
I'm asking because a coworker said "I think this comment doesn't accurately describe the code because X actually does Y". I was going to respond with "X actually doesn't do Y. Z is the one that actually does Y". However, it just sounds slightly snarky. I for sure would be a little annoyed if someone responded to me like that.
colleagues code
colleagues code
asked 1 hour ago
Jonathan Park
104
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
Jonathan Park
104
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
Jonathan Park
104
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 1 hour ago
Jonathan Park
104
asked 1 hour ago
Jonathan Park
104
104
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
Jonathan Park is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
1
Have you noticed the way others respond in code reviews? Have you seen cases where their responses didn't come across as passive-aggressive? Do that. Just stick with the facts and avoid passive-aggressive amplifiers like "actually" as much as you can.
– Joe Strazzere
1 hour ago
This seems highly dependent on culture and the personalities of those involved, and the specifics of the comment. Some don't really pick up on or mind snark and might dislike unnecessary sugarcoating, while others find snark in many things and appreciate some kinder ways of putting things. And someone might consider something snarky when it's said by one person, but not when it's said by another. Although you should always, within reason, try to avoid explaining or stating things others find obvious and always give the benefit of the doubt when interpreting what others say.
– Dukeling
34 mins ago
add a comment |
1
Have you noticed the way others respond in code reviews? Have you seen cases where their responses didn't come across as passive-aggressive? Do that. Just stick with the facts and avoid passive-aggressive amplifiers like "actually" as much as you can.
– Joe Strazzere
1 hour ago
This seems highly dependent on culture and the personalities of those involved, and the specifics of the comment. Some don't really pick up on or mind snark and might dislike unnecessary sugarcoating, while others find snark in many things and appreciate some kinder ways of putting things. And someone might consider something snarky when it's said by one person, but not when it's said by another. Although you should always, within reason, try to avoid explaining or stating things others find obvious and always give the benefit of the doubt when interpreting what others say.
– Dukeling
34 mins ago
1
1
Have you noticed the way others respond in code reviews? Have you seen cases where their responses didn't come across as passive-aggressive? Do that. Just stick with the facts and avoid passive-aggressive amplifiers like "actually" as much as you can.
– Joe Strazzere
1 hour ago
Have you noticed the way others respond in code reviews? Have you seen cases where their responses didn't come across as passive-aggressive? Do that. Just stick with the facts and avoid passive-aggressive amplifiers like "actually" as much as you can.
– Joe Strazzere
1 hour ago
This seems highly dependent on culture and the personalities of those involved, and the specifics of the comment. Some don't really pick up on or mind snark and might dislike unnecessary sugarcoating, while others find snark in many things and appreciate some kinder ways of putting things. And someone might consider something snarky when it's said by one person, but not when it's said by another. Although you should always, within reason, try to avoid explaining or stating things others find obvious and always give the benefit of the doubt when interpreting what others say.
– Dukeling
34 mins ago
This seems highly dependent on culture and the personalities of those involved, and the specifics of the comment. Some don't really pick up on or mind snark and might dislike unnecessary sugarcoating, while others find snark in many things and appreciate some kinder ways of putting things. And someone might consider something snarky when it's said by one person, but not when it's said by another. Although you should always, within reason, try to avoid explaining or stating things others find obvious and always give the benefit of the doubt when interpreting what others say.
– Dukeling
34 mins ago
add a comment |
2 Answers
2
active
oldest
votes
up vote
0
down vote
Your example states simple facts (if truly Z does Y) and would have been just fine as a reply.
The best answer would have been
"Actually Z does Y"
Concise, objective and precise without any personal context.
In professional conversations you stick to objective facts and established procedures.
You leave out personal comments or remarks, pointing fingers or attacking personally.
If someone made an obvious mistake that you're certain of or they misunderstood your own code, you're not only allowed but also obliged to correct them in a respectful manner, avoiding embarrassing or reprimanding them with other people present.
Stating objective facts is not passive aggression and anyone offended by them is unprofessional.
edited 31 mins ago
jcmack
7,24211539
answered 1 hour ago
DigitalBlade969
3,2051315
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
50 mins ago
add a comment |
up vote
0
down vote
The best way to correct anyone in a situation is by doing so in a manner that allows them to save face, especially when doing reviews like this.
The best way to do it is to act a bit unsure
Hmmmm... Let me just double check... Ah! Here we are. Z does Y. I'm sorry if I didn't comment that clearly enough.
Or something like that. You're right to feel that "X actually doesn't do Y. Z is the one that actually does Y". sounds snarky.
Another way you could phrase that is by gently nudging the person to walk through it again.
Let's check again.... Can you show me what's wrong?
and let the person find the mistake himself.
It's better to let a person save face than to be right.
answered 2 mins ago
Richard U
83.9k62217331
add a comment |
2 Answers
2
active
oldest
votes
2 Answers
2
active
oldest
votes
active
oldest
votes
active
oldest
votes
up vote
0
down vote
Your example states simple facts (if truly Z does Y) and would have been just fine as a reply.
The best answer would have been
"Actually Z does Y"
Concise, objective and precise without any personal context.
In professional conversations you stick to objective facts and established procedures.
You leave out personal comments or remarks, pointing fingers or attacking personally.
If someone made an obvious mistake that you're certain of or they misunderstood your own code, you're not only allowed but also obliged to correct them in a respectful manner, avoiding embarrassing or reprimanding them with other people present.
Stating objective facts is not passive aggression and anyone offended by them is unprofessional.
edited 31 mins ago
jcmack
7,24211539
answered 1 hour ago
DigitalBlade969
3,2051315
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
50 mins ago
add a comment |
up vote
0
down vote
Your example states simple facts (if truly Z does Y) and would have been just fine as a reply.
The best answer would have been
"Actually Z does Y"
Concise, objective and precise without any personal context.
In professional conversations you stick to objective facts and established procedures.
You leave out personal comments or remarks, pointing fingers or attacking personally.
If someone made an obvious mistake that you're certain of or they misunderstood your own code, you're not only allowed but also obliged to correct them in a respectful manner, avoiding embarrassing or reprimanding them with other people present.
Stating objective facts is not passive aggression and anyone offended by them is unprofessional.
edited 31 mins ago
jcmack
7,24211539
answered 1 hour ago
DigitalBlade969
3,2051315
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
50 mins ago
add a comment |
up vote
0
down vote
up vote
0
down vote
Your example states simple facts (if truly Z does Y) and would have been just fine as a reply.
The best answer would have been
"Actually Z does Y"
Concise, objective and precise without any personal context.
In professional conversations you stick to objective facts and established procedures.
You leave out personal comments or remarks, pointing fingers or attacking personally.
If someone made an obvious mistake that you're certain of or they misunderstood your own code, you're not only allowed but also obliged to correct them in a respectful manner, avoiding embarrassing or reprimanding them with other people present.
Stating objective facts is not passive aggression and anyone offended by them is unprofessional.
edited 31 mins ago
jcmack
7,24211539
answered 1 hour ago
DigitalBlade969
3,2051315
Your example states simple facts (if truly Z does Y) and would have been just fine as a reply.
The best answer would have been
"Actually Z does Y"
Concise, objective and precise without any personal context.
In professional conversations you stick to objective facts and established procedures.
You leave out personal comments or remarks, pointing fingers or attacking personally.
If someone made an obvious mistake that you're certain of or they misunderstood your own code, you're not only allowed but also obliged to correct them in a respectful manner, avoiding embarrassing or reprimanding them with other people present.
Stating objective facts is not passive aggression and anyone offended by them is unprofessional.
edited 31 mins ago
jcmack
7,24211539
answered 1 hour ago
DigitalBlade969
3,2051315
edited 31 mins ago
jcmack
7,24211539
edited 31 mins ago
jcmack
7,24211539
edited 31 mins ago
jcmack
7,24211539
7,24211539
answered 1 hour ago
DigitalBlade969
3,2051315
answered 1 hour ago
DigitalBlade969
3,2051315
answered 1 hour ago
DigitalBlade969
3,2051315
3,2051315
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
50 mins ago
add a comment |
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
50 mins ago
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
50 mins ago
Bonus points if you point to documentation that proves "Z does Y".
– jcmack
50 mins ago
add a comment |
up vote
0
down vote
The best way to correct anyone in a situation is by doing so in a manner that allows them to save face, especially when doing reviews like this.
The best way to do it is to act a bit unsure
Hmmmm... Let me just double check... Ah! Here we are. Z does Y. I'm sorry if I didn't comment that clearly enough.
Or something like that. You're right to feel that "X actually doesn't do Y. Z is the one that actually does Y". sounds snarky.
Another way you could phrase that is by gently nudging the person to walk through it again.
Let's check again.... Can you show me what's wrong?
and let the person find the mistake himself.
It's better to let a person save face than to be right.
answered 2 mins ago
Richard U
83.9k62217331
add a comment |
up vote
0
down vote
The best way to correct anyone in a situation is by doing so in a manner that allows them to save face, especially when doing reviews like this.
The best way to do it is to act a bit unsure
Hmmmm... Let me just double check... Ah! Here we are. Z does Y. I'm sorry if I didn't comment that clearly enough.
Or something like that. You're right to feel that "X actually doesn't do Y. Z is the one that actually does Y". sounds snarky.
Another way you could phrase that is by gently nudging the person to walk through it again.
Let's check again.... Can you show me what's wrong?
and let the person find the mistake himself.
It's better to let a person save face than to be right.
answered 2 mins ago
Richard U
83.9k62217331
add a comment |
up vote
0
down vote
up vote
0
down vote
The best way to correct anyone in a situation is by doing so in a manner that allows them to save face, especially when doing reviews like this.
The best way to do it is to act a bit unsure
Hmmmm... Let me just double check... Ah! Here we are. Z does Y. I'm sorry if I didn't comment that clearly enough.
Or something like that. You're right to feel that "X actually doesn't do Y. Z is the one that actually does Y". sounds snarky.
Another way you could phrase that is by gently nudging the person to walk through it again.
Let's check again.... Can you show me what's wrong?
and let the person find the mistake himself.
It's better to let a person save face than to be right.
answered 2 mins ago
Richard U
83.9k62217331
The best way to correct anyone in a situation is by doing so in a manner that allows them to save face, especially when doing reviews like this.
The best way to do it is to act a bit unsure
Hmmmm... Let me just double check... Ah! Here we are. Z does Y. I'm sorry if I didn't comment that clearly enough.
Or something like that. You're right to feel that "X actually doesn't do Y. Z is the one that actually does Y". sounds snarky.
Another way you could phrase that is by gently nudging the person to walk through it again.
Let's check again.... Can you show me what's wrong?
and let the person find the mistake himself.
It's better to let a person save face than to be right.
answered 2 mins ago
Richard U
83.9k62217331
answered 2 mins ago
Richard U
83.9k62217331
answered 2 mins ago
Richard U
83.9k62217331
answered 2 mins ago
Richard U
83.9k62217331
83.9k62217331
add a comment |
add a comment |
Jonathan Park is a new contributor. Be nice, and check out our Code of Conduct.
Jonathan Park is a new contributor. Be nice, and check out our Code of Conduct.
Jonathan Park is a new contributor. Be nice, and check out our Code of Conduct.
Jonathan Park is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to The Workplace Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Some of your past answers have not been well-received, and you're in danger of being blocked from answering.
Please pay close attention to the following guidance:
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f124438%2fhow-to-not-sound-passive-aggressive-in-code-reviews%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
1
Have you noticed the way others respond in code reviews? Have you seen cases where their responses didn't come across as passive-aggressive? Do that. Just stick with the facts and avoid passive-aggressive amplifiers like "actually" as much as you can.
– Joe Strazzere
1 hour ago
This seems highly dependent on culture and the personalities of those involved, and the specifics of the comment. Some don't really pick up on or mind snark and might dislike unnecessary sugarcoating, while others find snark in many things and appreciate some kinder ways of putting things. And someone might consider something snarky when it's said by one person, but not when it's said by another. Although you should always, within reason, try to avoid explaining or stating things others find obvious and always give the benefit of the doubt when interpreting what others say.
– Dukeling
34 mins ago