How to deal with senior developer who slows me down intentionally
It's been a couple of weeks since I started my new job as a mid level web dev.
There's an ongoing project on which only me and the senior developer (who is also new here) are working on. As in most teams, changes come in pull requests and someone else has to review your code to merge it.
Once I got the hang of the codebase I started creating a lot of PRs that contained features/patches/fixes mentioned in our ticketing system, but the last couple of days I see my PRs stacking up and not getting merged.
Initially, I though that my coworker didn't have enough time to review. Unfortunately, I found out that he is not merging my code intentionally even though this slows the whole project down.
I fear he is feeling threatened by my performance and he is trying to artificially slow me down. How am I supposed to deal with it?
Let me answer some questions before they come up:
Q: Are your PRs too large to review and he feels fatigued?
A: Most PRs include no more than 10 lines of code. I try to keep them
small and focused. There's even a PR with 1 line change. Of course,
some are larger, but they are very few.
Q: Maybe your code is really bad and he doesn't know how to address it?
A: Since day 1 I showed everyone that not only do I welcome feedback on my code, but I actively ask for it. I've addressed every single comment on my PRs and when I'm not 100% sure about my approach... I do as others suggest. I've even changed my code even when I disagreed, just to show that I'm cooperative.
Q: Maybe he really doesn't have any time to review?
A: Nope, I can see him working on objectively less-prioritized issues
Q: How can you be sure he is "intentionally" not merging your code?
A: The most obvious example is a comment he left on one on my PRs. He stated that he looked at the code, it looks good, but it was low-priority feature and he felt that I should have spent my time on something more important. Even if that were true (which was not: the feature was on the high-priority list and only took me 15 minutes to implement) why wouldn't he merge the code?
Again... how do I deal with this?
I do not want to cause a toxic situation.
I would like to make him feel safe, I'm not a threat.
Contacting management is only a last resort solution for me.
seniority competition
New contributor
John Rambo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
It's been a couple of weeks since I started my new job as a mid level web dev.
There's an ongoing project on which only me and the senior developer (who is also new here) are working on. As in most teams, changes come in pull requests and someone else has to review your code to merge it.
Once I got the hang of the codebase I started creating a lot of PRs that contained features/patches/fixes mentioned in our ticketing system, but the last couple of days I see my PRs stacking up and not getting merged.
Initially, I though that my coworker didn't have enough time to review. Unfortunately, I found out that he is not merging my code intentionally even though this slows the whole project down.
I fear he is feeling threatened by my performance and he is trying to artificially slow me down. How am I supposed to deal with it?
Let me answer some questions before they come up:
Q: Are your PRs too large to review and he feels fatigued?
A: Most PRs include no more than 10 lines of code. I try to keep them
small and focused. There's even a PR with 1 line change. Of course,
some are larger, but they are very few.
Q: Maybe your code is really bad and he doesn't know how to address it?
A: Since day 1 I showed everyone that not only do I welcome feedback on my code, but I actively ask for it. I've addressed every single comment on my PRs and when I'm not 100% sure about my approach... I do as others suggest. I've even changed my code even when I disagreed, just to show that I'm cooperative.
Q: Maybe he really doesn't have any time to review?
A: Nope, I can see him working on objectively less-prioritized issues
Q: How can you be sure he is "intentionally" not merging your code?
A: The most obvious example is a comment he left on one on my PRs. He stated that he looked at the code, it looks good, but it was low-priority feature and he felt that I should have spent my time on something more important. Even if that were true (which was not: the feature was on the high-priority list and only took me 15 minutes to implement) why wouldn't he merge the code?
Again... how do I deal with this?
I do not want to cause a toxic situation.
I would like to make him feel safe, I'm not a threat.
Contacting management is only a last resort solution for me.
seniority competition
New contributor
John Rambo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
It's been a couple of weeks since I started my new job as a mid level web dev.
There's an ongoing project on which only me and the senior developer (who is also new here) are working on. As in most teams, changes come in pull requests and someone else has to review your code to merge it.
Once I got the hang of the codebase I started creating a lot of PRs that contained features/patches/fixes mentioned in our ticketing system, but the last couple of days I see my PRs stacking up and not getting merged.
Initially, I though that my coworker didn't have enough time to review. Unfortunately, I found out that he is not merging my code intentionally even though this slows the whole project down.
I fear he is feeling threatened by my performance and he is trying to artificially slow me down. How am I supposed to deal with it?
Let me answer some questions before they come up:
Q: Are your PRs too large to review and he feels fatigued?
A: Most PRs include no more than 10 lines of code. I try to keep them
small and focused. There's even a PR with 1 line change. Of course,
some are larger, but they are very few.
Q: Maybe your code is really bad and he doesn't know how to address it?
A: Since day 1 I showed everyone that not only do I welcome feedback on my code, but I actively ask for it. I've addressed every single comment on my PRs and when I'm not 100% sure about my approach... I do as others suggest. I've even changed my code even when I disagreed, just to show that I'm cooperative.
Q: Maybe he really doesn't have any time to review?
A: Nope, I can see him working on objectively less-prioritized issues
Q: How can you be sure he is "intentionally" not merging your code?
A: The most obvious example is a comment he left on one on my PRs. He stated that he looked at the code, it looks good, but it was low-priority feature and he felt that I should have spent my time on something more important. Even if that were true (which was not: the feature was on the high-priority list and only took me 15 minutes to implement) why wouldn't he merge the code?
Again... how do I deal with this?
I do not want to cause a toxic situation.
I would like to make him feel safe, I'm not a threat.
Contacting management is only a last resort solution for me.
seniority competition
New contributor
John Rambo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
It's been a couple of weeks since I started my new job as a mid level web dev.
There's an ongoing project on which only me and the senior developer (who is also new here) are working on. As in most teams, changes come in pull requests and someone else has to review your code to merge it.
Once I got the hang of the codebase I started creating a lot of PRs that contained features/patches/fixes mentioned in our ticketing system, but the last couple of days I see my PRs stacking up and not getting merged.
Initially, I though that my coworker didn't have enough time to review. Unfortunately, I found out that he is not merging my code intentionally even though this slows the whole project down.
I fear he is feeling threatened by my performance and he is trying to artificially slow me down. How am I supposed to deal with it?
Let me answer some questions before they come up:
Q: Are your PRs too large to review and he feels fatigued?
A: Most PRs include no more than 10 lines of code. I try to keep them
small and focused. There's even a PR with 1 line change. Of course,
some are larger, but they are very few.
Q: Maybe your code is really bad and he doesn't know how to address it?
A: Since day 1 I showed everyone that not only do I welcome feedback on my code, but I actively ask for it. I've addressed every single comment on my PRs and when I'm not 100% sure about my approach... I do as others suggest. I've even changed my code even when I disagreed, just to show that I'm cooperative.
Q: Maybe he really doesn't have any time to review?
A: Nope, I can see him working on objectively less-prioritized issues
Q: How can you be sure he is "intentionally" not merging your code?
A: The most obvious example is a comment he left on one on my PRs. He stated that he looked at the code, it looks good, but it was low-priority feature and he felt that I should have spent my time on something more important. Even if that were true (which was not: the feature was on the high-priority list and only took me 15 minutes to implement) why wouldn't he merge the code?
Again... how do I deal with this?
I do not want to cause a toxic situation.
I would like to make him feel safe, I'm not a threat.
Contacting management is only a last resort solution for me.
seniority competition
seniority competition
New contributor
John Rambo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
John Rambo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
John Rambo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
asked 6 mins ago
John RamboJohn Rambo
1
1
New contributor
John Rambo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
New contributor
John Rambo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
John Rambo is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.
add a comment |
add a comment |
0
active
oldest
votes
Your Answer
StackExchange.ready(function() {
var channelOptions = {
tags: "".split(" "),
id: "423"
};
initTagRenderer("".split(" "), "".split(" "), channelOptions);
StackExchange.using("externalEditor", function() {
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled) {
StackExchange.using("snippets", function() {
createEditor();
});
}
else {
createEditor();
}
});
function createEditor() {
StackExchange.prepareEditor({
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader: {
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
},
noCode: true, onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
});
}
});
John Rambo is a new contributor. Be nice, and check out our Code of Conduct.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f130436%2fhow-to-deal-with-senior-developer-who-slows-me-down-intentionally%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
0
active
oldest
votes
0
active
oldest
votes
active
oldest
votes
active
oldest
votes
John Rambo is a new contributor. Be nice, and check out our Code of Conduct.
John Rambo is a new contributor. Be nice, and check out our Code of Conduct.
John Rambo is a new contributor. Be nice, and check out our Code of Conduct.
John Rambo is a new contributor. Be nice, and check out our Code of Conduct.
Thanks for contributing an answer to The Workplace Stack Exchange!
- Please be sure to answer the question. Provide details and share your research!
But avoid …
- Asking for help, clarification, or responding to other answers.
- Making statements based on opinion; back them up with references or personal experience.
To learn more, see our tips on writing great answers.
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
StackExchange.ready(
function () {
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fworkplace.stackexchange.com%2fquestions%2f130436%2fhow-to-deal-with-senior-developer-who-slows-me-down-intentionally%23new-answer', 'question_page');
}
);
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Sign up or log in
StackExchange.ready(function () {
StackExchange.helpers.onClickDraftSave('#login-link');
});
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Sign up using Google
Sign up using Facebook
Sign up using Email and Password
Post as a guest
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown
Required, but never shown